Disallow extra fields other than "@context"#266
Draft
candleindark wants to merge 8 commits intodandi:masterfrom
Draft
Disallow extra fields other than "@context"#266candleindark wants to merge 8 commits intodandi:masterfrom
"@context"#266candleindark wants to merge 8 commits intodandi:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #75. It addresses #75 in the follow manner.
"@context"field in both Pydantic and JSON level."@context"field can be validated against a Pydantic model but ignored.The solution implemented in this PR is based on the following script.
TODOs
@contextoptional and then discuss*/*/dandiset.jsonldfiles under/mnt/backup/dandi/dandiset-manifests-s3cmd."@context"#266 (comment))diff-manifests-reportssubcommand of https://github.com/dandi/dandisets-linkml-status-tools is the tool for the checking